From: Florian Müllner <fmuellner@gnome.org>
Date: Sat, 2 Mar 2019 19:46:28 +0000 (+0100)
Subject: network: Don't destroy wireless dialog twice
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~888^2^2~35
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=5f2bd7069021582d16c6a329ccaeaa269c73a3ac;p=gnome-shell.git

network: Don't destroy wireless dialog twice

The dialog doesn't change the `destroyOnClose` property from its default,
so it is already destroyed automatically on close. So if we also destroy
it explicitly, we end up (rightfully) with one of gjs' infamous "invalid
access" warnings.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/430
---

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 21cbeac61..77a6202b8 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -1236,7 +1236,6 @@ var NMDeviceWireless = class {
     }
 
     _dialogClosed() {
-        this._dialog.destroy();
         this._dialog = null;
     }